cangen: make FD/XL content configurable in mixed mode#600
Closed
hartkopp wants to merge 0 commit into
Closed
Conversation
Member
|
Let's discuss you approach in #599 |
Member
|
Cc: @vincent-mailhol |
Contributor
|
```c
if (mix && (!canfd_en && !canxl_en)) {
printf("-f and/or -X is required for -m (mixed mode)!\n");
return 1;
}
```
This is not what I intended in my initial patch. The goal was to have the cangen
automagically handle the logic for me so that I do not have to think about what
flag to pass and this regardless of the interface capabilities.
This actually goes in the opposite direction as I would now not be able to use
-m alone.
When testing, I use the cangen -m a lot an I always have this little frustration
when getting the error message when the interface only support Classical CAN.
|
Member
|
IMHO having the mixed mode doing the maximum mixing of the supported interface's capabilities is a good idea. |
Member
Author
|
Ok, got it. Will prepare another patch. |
Member
Author
|
Hey all, I force pushed the patch on my master branch and did not realize that this automatically changed this pull request. |
Member
|
FTR: new PR: #601 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested-by: Vincent Mailhol mailhol@kernel.org