mlx5: fix max length of hostname #1535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xiaolin Zhang <[email protected]>
leoncamel
force-pushed
the
fixing-hostname-length
branch
from
1a3e006 to
b57fc8a
Compare
|
We use kernel coding style. Please add description to commit message and set Fixes line. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current length of
mlx5_context.hostnameis a 40 bytes long. According togethostname's man-page, and also the standard of POSIX. The maximum length isHOST_NAME_MAX, which is 64 bytes.And also, the RFC1034, the maximum length is also about 64 bytes.
So, I made this patch to follow the standards.