ionic: Add ionic provider #1620
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijitG-xlnx
force-pushed
the
upstream_ionic_rdma
branch
from
7074e2a to
68709b3
Compare
|
please rebase |
rleon
reviewed
Sep 15, 2025
| #include <stdlib.h> | ||
|
|
||
| #include "ionic.h" | ||
|
|
There was a problem hiding this comment.
- Please start without environmental variables. It is legacy, which we are trying to get rid of.
- Use verbs_debug() for DEBUG functionality.
There was a problem hiding this comment.
Thanks. Will remove the env variables and use the verbs logging.
rleon
reviewed
Sep 15, 2025
providers/ionic/ionic.c
Outdated
| } | ||
|
|
||
| if (resp.version > IONIC_MAX_RDMA_VERSION) { | ||
| fprintf(stderr, "ionic: Firmware RDMA Version %u\n", |
There was a problem hiding this comment.
Please without prints/fprints in library code.
rleon
reviewed
Sep 15, 2025
providers/ionic/ionic.h
Outdated
| return BIT(ctx->udma_count) - 1; | ||
| } | ||
|
|
||
| #ifndef IONIC_DEBUG |
This patch is to be autogenerated from commit hash using kernel-headers/update script after kernel driver is merged. Signed-off-by: Abhijit Gangurde <[email protected]>
Introduce a provider for AMD pensando ionic devices to user applications. Co-developed-by: Andrew Boyer <[email protected]> Signed-off-by: Andrew Boyer <[email protected]> Co-developed-by: Allen Hubbe <[email protected]> Signed-off-by: Allen Hubbe <[email protected]> Signed-off-by: Abhijit Gangurde <[email protected]>
abhijitG-xlnx
force-pushed
the
upstream_ionic_rdma
branch
from
68709b3 to
e717272
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a provider for AMD pensando ionic device to user applications.