efa: Extend DV query CQ to return doorbell #1646
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rleon
reviewed
Sep 15, 2025
| uint8_t *buffer; | ||
| uint32_t entry_size; | ||
| uint32_t num_entries; | ||
| uint32_t *doorbell; |
There was a problem hiding this comment.
If it is address, why is it uint32_t and not uint64_t?
There was a problem hiding this comment.
The doorbell is 32 bits and I prefer returning a relevant pointer type rather than an address, in similar to what we do in efadv_query_qp_wqs.
Changed the commit message to better reflect on this.
Return the CQ reverse doorbell to give external data path implementations (GPU, etc.) an option to notify the device of polled entries. Reviewed-by: Yonatan Nachum <[email protected]> Signed-off-by: Michael Margolin <[email protected]>
mrgolin
force-pushed
the
cq_doorbell
branch
from
be30c78 to
93e224f
Compare
mrgolin
changed the title
|
@rleon if there are no further comments, can you please merge this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return the CQ reverse doorbell to give external data path implementations (GPU, etc.) an option to notify the device of polled entries.