Repository navigation
fix(compat): support Qt 5.11 and GCC 8 toolchain - #813
Conversation
Guard the two new errorOccurred connects so Qt < 5.15 keeps using error(QAbstractSocket::SocketError), matching the existing pattern in singleapplication.cpp. Link stdc++fs when compiling with GCC < 9, where std::filesystem symbols live in a separate archive (UOS 20 toolchain); GCC >= 9 folds them into libstdc++. Log: support Qt 5.11 and GCC 8 toolchain Influence: no behavior change on Qt >= 5.15 and GCC >= 9; makes the tunnel branch build on Qt 5.11.3 (UOS 20).
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe patch makes the tunnel branch build with Qt 5.11 and GCC 8 by selecting the legacy socket error signal on older Qt releases and linking stdc++fs for pre-GCC 9 toolchains, without changing behavior on newer environments. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review🤖 AI 代码审查报告📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价: 语法正确,逻辑清晰 ✅ 通过 潜在问题: 建议: ['无需修改,语法逻辑完全正确。'] 2. 代码质量 ✅评价: 代码结构清晰,注释完整 ✅ 通过 潜在问题: 建议: ["sharehelper.cpp 中 '// Error handling function' 注释可更具体,如 '// Qt 5.15 以下使用 error 重载信号,5.15+ 使用 errorOccurred',但属于轻微建议。"] 3. 代码性能 ✅评价: 性能良好,资源使用合理 ✅ 通过 潜在问题: 建议: ['无需优化,本次变更不涉及性能相关改动。'] 4. 代码安全 🔒评价: 存在0个安全漏洞 ✅ 通过
安全漏洞详情: 建议: ['无需安全加固,本次变更不涉及安全敏感操作。'] 💡 改进建议代码示例本报告由 AI 代码审查工具自动生成 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, re2zero The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Cherry-picked from
6f39dc937daon the original tunnel work branch; the patch applies cleanly to current master and is identical to the original commit.Guard the two new
errorOccurredconnects so Qt < 5.15 keeps usingerror(QAbstractSocket::SocketError), matching the existing pattern insingleapplication.cpp. Linkstdc++fswhen compiling with GCC < 9, wherestd::filesystemsymbols live in a separate archive (UOS 20 toolchain);GCC >= 9 folds them into libstdc++.
Log: support Qt 5.11 and GCC 8 toolchain
Influence: no behavior change on Qt >= 5.15 and GCC >= 9; makes the tunnel branch build on Qt 5.11.3 (UOS 20).
Summary by Sourcery
Support building the project with Qt 5.11 and GCC 8 toolchains while preserving existing behavior on newer versions.
Bug Fixes:
Build: