Skip to content

fix: keep system proxy switch visible to allow creating proxy - #644

Merged
caixr23 merged 1 commit into
linuxdeepin:masterfrom
caixr23:master
Oct 16, 2026
Merged

caixr23 merged 1 commit into
linuxdeepin:masterfrom
caixr23:master

Conversation

@caixr23

@caixr23 caixr23 commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor
  1. Remove "visible: netItem.enabledable" from the switch inside the system proxy page (dcc-network/qml/PageSystemProxy.qml) so the switch stays visible.

fix: 保持系统代理页面开关可见以允许创建代理

  1. 移除系统代理页面(dcc-network/qml/PageSystemProxy.qml)中开关上的 "visible: netItem.enabledable",使开关保持可见。

PMS: BUG-379885

Summary by Sourcery

Bug Fixes:

  • Keep the system proxy switch visible so users can create or enable a proxy when no enabled proxy item is available.

1. Remove "visible: netItem.enabledable" from the switch inside the
   system proxy page (dcc-network/qml/PageSystemProxy.qml) so the
   switch stays visible.

fix: 保持系统代理页面开关可见以允许创建代理

1. 移除系统代理页面(dcc-network/qml/PageSystemProxy.qml)中开关上的
   "visible: netItem.enabledable",使开关保持可见。

PMS: BUG-379885
@sourcery-ai

sourcery-ai Bot commented Oct 16, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The system proxy page now always displays its switch by removing the enablement-based visibility condition, while leaving its state and interaction logic unchanged so a proxy can be created.

File-Level Changes

Change Details Files
Keep the system proxy toggle rendered regardless of the network item's enablement state.
  • Removed the conditional visibility binding from the proxy switch.
  • Preserved the existing checked state and click behavior, allowing users to initiate proxy creation when no enabled proxy item exists.
dcc-network/qml/PageSystemProxy.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

🤖 AI 代码审查报告

总体评分: 100 分 (通过阈值: 70分)

Pass


📊 总体评价

项目 结果
审查结论 代码审查通过
评分详情 总体评分 100 分,大于 70 分通过阈值,代码质量符合要求。本次变更移除了系统代理页面开关上的 visible: netItem.enabledable 属性绑定,使开关保持始终可见,符合 commit message 中描述的修复目的。

🔍 详细分析

1. 语法逻辑 ✅

评价: 优秀 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 语法正确,移除属性绑定是有效的 QML 操作,无需额外修改


2. 代码质量 ✅

评价: 优秀 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 代码变更简洁明了,仅移除一行不必要的属性绑定,符合最小化修改原则


3. 代码性能 ✅

评价: 优秀 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 移除属性绑定减少了绑定求值开销,对性能有轻微正面影响


4. 代码安全 🔒

评价: 优秀 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情:
✅ 未发现安全漏洞

建议: 本次变更不涉及安全敏感操作,无需安全加固


💡 改进建议代码示例

// 本次变更为移除一行属性绑定(visible: netItem.enabledable),
// 使系统代理开关始终保持可见,符合修复目的,无需额外修复代码。

本报告由 AI 代码审查工具自动生成

@caixr23
caixr23 requested a review from mhduiy October 16, 2026 08:24
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caixr23
caixr23 merged commit 260d677 into linuxdeepin:master Oct 16, 2026
14 checks passed

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants