Skip to content

Conversation

emlimlf
Copy link
Collaborator

@emlimlf emlimlf commented Oct 3, 2025

In this PR

  • Breakout the banner to a separate component
  • Implemented design improvement on the kubecon banner

Ticket

IN-716

@emlimlf emlimlf requested review from Copilot and gaspergrom October 3, 2025 05:43
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the KubeCon banner by refactoring it into a separate component and implementing design improvements. The banner content and functionality remain the same, but it's now modularized for better maintainability.

Key changes:

  • Extracted banner HTML from navbar component into a dedicated banner.vue component
  • Updated banner styling with responsive design improvements including new background color and typography
  • Added component import to navbar to use the new banner component

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
frontend/app/components/shared/layout/navbar.vue Removed inline banner HTML and added import for new banner component
frontend/app/components/shared/layout/banner.vue New component containing the KubeCon banner with improved responsive styling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

-->
<template>
<div
class="block bg-brand-800 text-white sm:py-1 py-2 px-5 sm:text-xs sm:leading-4 flex
Copy link

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class attribute contains conflicting CSS declarations. 'block' and 'flex' display properties conflict with each other. Remove 'block' since 'flex' takes precedence and is the intended behavior.

Suggested change
class="block bg-brand-800 text-white sm:py-1 py-2 px-5 sm:text-xs sm:leading-4 flex
class="bg-brand-800 text-white sm:py-1 py-2 px-5 sm:text-xs sm:leading-4 flex

Copilot uses AI. Check for mistakes.

Comment on lines +7 to +8
class="block bg-brand-800 text-white sm:py-1 py-2 px-5 sm:text-xs sm:leading-4 flex
items-center sm:justify-center justify-start gap-3 text-2xs leading-3.5"
Copy link

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicting text size classes: 'sm:text-xs' and 'text-2xs' may cause unexpected behavior. Consider using a consistent approach like 'text-2xs sm:text-xs' to be more explicit about the responsive behavior.

Suggested change
class="block bg-brand-800 text-white sm:py-1 py-2 px-5 sm:text-xs sm:leading-4 flex
items-center sm:justify-center justify-start gap-3 text-2xs leading-3.5"
class="block bg-brand-800 text-white sm:py-1 py-2 px-5 sm:leading-4 flex
items-center sm:justify-center justify-start gap-3 text-2xs sm:text-xs leading-3.5"

Copilot uses AI. Check for mistakes.

@emlimlf emlimlf merged commit b2018ee into main Oct 6, 2025
10 checks passed
@emlimlf emlimlf deleted the feat/banner-improvements branch October 6, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant