Skip to content

Improve code quality and performance in portalHandlers.js #12993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve code quality and performance in portalHandlers.js #12993

wants to merge 1 commit into from

Conversation

nitin-is-me
Copy link

This PR makes small code quality improvements to js/misc/portalHandlers.js:

Changes:

  • Fixed missing semicolon
  • Simplified has_focus() method by using Array.includes() instead of manual loop
  • Improved GetAppStates() method structure

Testing:

  • No functional changes, existing portal functionality should work unchanged
  • Code maintains the same behavior while being more concise and readable

These are minor refactoring improvements with no impact on functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nitin-is-me