-
-
Notifications
You must be signed in to change notification settings - Fork 11
Switch to Github latest release #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! Be sure to follow the pull request template!
The arm version fails to build, because Jenkins is building 0.20.2 which on github doesnt have a binary for arm64 I am not sure how to get the jenkins server to build 1.0.0 version. However it definitely works locally for me. |
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
Still valid as an alternative while pr #6 is not merged |
Description:
Switch away from debian package (still outdated at 0.20.2) to the github appimage release.
Benefits of this PR and context:
In short, currently it provides Freecad 1.0 which is much improved over 0.20.2
Updated to always point to the "latest" release by default. However I did test and it is possible to use 0.20.2 as a build arg to build 0.20.2 as an example. The weekly release I think will only work, if they contain an asset for x86_64 or aarch64 which sometimes for me didn't work.
So, unlike PR #6 this does not have the release hardcoded. I used the orcaslicer repo for inspiration.
How Has This Been Tested?
Built the latest version using command:
Then stopped my container, deleted it and used docker compose to load it up. I then browsed to the url to confirm version 1.0.0 is installed and usable.
docker-compse:
In the browser, it looks like this:

Tested the version ARG with:
This also worked in the browser showing the expected version is installed.
Source / References:
Closes #4