Skip to content

fix currency format for different locale #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alepop wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix currency format for different locale #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 12 additions & 18 deletions src/utils/formatting.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,22 @@
import numeral from 'numeral';

const formatNumber = (amount, currency, options = {}) => {
if (!(options.maximumFractionDigits || options.maximumFractionDigits === 0)) {
if (
!(options.maximumFractionDigits || options.maximumFractionDigits === 0) &&
currency
) {
options.maximumFractionDigits = Math.max(
0,
7 - parseInt(amount, 10).toString().length
);
}

let value = new Intl.NumberFormat(navigator.language, {
style: 'decimal',
...options,
}).format(Math.abs(amount));
if (!currency || options.minPrecision) {
options.maximumFractionDigits = 2;
options.minimumFractionDigits = 2;
}

let value = new Intl.NumberFormat(navigator.language, options).format(
Math.abs(amount)
);

if (currency) {
value = `$${value}`;
Expand All @@ -22,17 +27,6 @@ const formatNumber = (amount, currency, options = {}) => {
value = `${direction}${value}`;
}

if (options.minPrecision) {
// Set min precision
value = value.replace(/\d+(?:,\d+)*(?:\.\d+)?/, match => {
const matchValue = parseFloat(match.replace(/,/g, ''));
if (matchValue >= 0.1 || options.directionSymbol) {
match = numeral(matchValue).format('0,0.00');
}
return match;
});
}

return value;
};

Expand Down