Adding support for google oauth2 authentication in the omni-executor #3244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements Display trait for AuthenticationError to provide better error messages for logging and user feedback. This also fixes the dead code warning for AuthTokenError variant.
Adds implementation of Google OAuth2 token verification for authentication. This includes: - State verifier validation - Token exchange using authorization code - ID token decoding and validation - Identity verification against sender's identity
Changes auth token claims to use sender identity hash instead of omni account. This simplifies the auth token verification process by removing the dependency on omni account storage and making the verification more direct.
kziemianek
approved these changes
Jan 29, 2025
| @@ -0,0 +1,102 @@ | |||
| mod oauth2_client; | |||
There was a problem hiding this comment.
Can this be moved out of identity-verificaiton / heima context ? To me it looks like just general oauth
There was a problem hiding this comment.
Sure, in the identity worker we have this in litentry/core/data-providers but since we are not sure if we are going to support the identity/vc related stuff in the omni-executor I didn't create that structure. I'll create an oauth-providers crate as we might add support for others
Implements a new RPC endpoint `omni_getOAuth2GoogleAuthorizationUrl` that generates and returns an authorization URL for Google OAuth2 authentication flow. The endpoint: - Takes Google account and redirect URI as parameters - Stores state verifier in database for security - Returns hex-encoded authorization URL - Integrates with existing identity verification system
Moves Google OAuth2 client implementation from identity-verification crate to the new oauth-providers crate for better code organization.
silva-fj
deleted the
p-1284-add-support-for-google-oauth2-authentication
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for google oauth2 authentication for native calls as well as some refactoring: Renamed the
primitivescrate toexecutor-primitivesand updated all relevant references in the codebase.