Skip to content

Conversation

@Harshal6927
Copy link
Member

Description

Closes

#596

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.69%. Comparing base (8bdcb0d) to head (c6665be).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #598      +/-   ##
==========================================
+ Coverage   79.67%   79.69%   +0.01%     
==========================================
  Files          87       87              
  Lines        6392     6396       +4     
  Branches      824      824              
==========================================
+ Hits         5093     5097       +4     
  Misses       1043     1043              
  Partials      256      256              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@renjianguo666
Copy link

Hi! Thanks for the quick fix! However, there's a follow-up issue with the current implementation.

Problem
After the recent changes, the autogenerated migration now includes:

image

NameError: name 'Argon2Hasher' is not defined

===============================
Sorry, I don't understand English. Only translation software and illustrations can be used to illustrate the situation

image image

@Harshal6927
Copy link
Member Author

Thanks for the comment, @renjianguo666. We’re aware of this issue, which is why this PR is currently in draft status. We’re working on finding a suitable approach to enable automatic imports in the migration file.

@Harshal6927 Harshal6927 marked this pull request as ready for review November 2, 2025 18:54
@Harshal6927 Harshal6927 requested review from a team as code owners November 2, 2025 18:54
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2025

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

Documentation preview will be available shortly at https://litestar-org.github.io/advanced-alchemy-docs-preview/598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: PasswordHash breaks Alembic autogenerate when backend is required

5 participants