feat(workflow-controller): make log level configurable #475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds the ability to override the workflow-controller log level and glog verbosity via Helm values. Today
--loglevelis hardcoded todebugand--gloglevelto"1"in the Deployment, so operators cannot reduce log volume without forking or post-rendering.In multi-cluster setups (e.g. 20+ clusters), the litmus-agent-workflow-controller at debug generates a large amount of logs (e.g. 30k+ records per 15 minutes), increasing ingestion and storage cost. This change adds:
appSettings.loglevel(default:debug, for compatibility) — controls the application log level (debug, info, warn, error). Installers can set e.g.workflow-controller.appSettings.loglevel: "info"to cut debug noise.appSettings.gloglevel(default:"1", for compatibility) — controls glog verbosity (numeric; higher = more verbose). Installers can set e.g.workflow-controller.appSettings.gloglevel: "0"to reduce glog output.Both keep existing behavior by default so the chart remains backward compatible.
Which issue this PR fixes
fixes #474
Special notes for your reviewer:
loglevel: debugandgloglevel: "1"for backward compatibility.litmus-agent/Chart.yamldependency on workflow-controller updated to 0.2.3.Checklist
@Vr00mm @ispeakc0de @Jonsy13