Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update code syntax in backend server #4944

Merged
merged 10 commits into from
Jan 15, 2025

Conversation

jemlog
Copy link
Contributor

@jemlog jemlog commented Nov 15, 2024

Proposed changes

Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue

  • I improved the GraphQL server codebase by eliminating unnecessary variable declarations and redundant conditional statements.
  • I also removed potential risks of nil pointer exceptions.

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

@jemlog jemlog force-pushed the refactor/fix-conditions branch from eafa9c8 to 0f78ca6 Compare November 15, 2024 13:18
@jemlog jemlog changed the title refactor: update codes in backend server refactor: update code syntax in backend server Nov 15, 2024
Copy link
Member

@namkyu1999 namkyu1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Saranya-jena Saranya-jena merged commit 54579b1 into litmuschaos:master Jan 15, 2025
19 checks passed
andoriyaprashant pushed a commit to andoriyaprashant/litmus that referenced this pull request Jan 18, 2025
* refactor: update codes in backend server

Signed-off-by: Jemin <[email protected]>

* refactor: add space

Signed-off-by: Jemin <[email protected]>

* refactor: add space

Signed-off-by: Jemin <[email protected]>

---------

Signed-off-by: Jemin <[email protected]>
Co-authored-by: Namkyu Park <[email protected]>
Co-authored-by: Amit Kumar Das <[email protected]>
Co-authored-by: Saranya Jena <[email protected]>
Signed-off-by: andoriyaprashant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants