Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding initial gateway list with environment variable #36

Closed
wants to merge 4 commits into from

Conversation

John-LittleBearLabs
Copy link
Collaborator

@John-LittleBearLabs John-LittleBearLabs commented Jun 15, 2023

resolve #29

This doesn't turn off discovered additional gateways. Perhaps it should?

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage: 94.44% and project coverage change: +1.33 🎉

Comparison is base (fead8ff) 51.14% compared to head (fde03d1) 52.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##            cidv0      #36      +/-   ##
==========================================
+ Coverage   51.14%   52.47%   +1.33%     
==========================================
  Files          48       48              
  Lines        2364     2382      +18     
==========================================
+ Hits         1209     1250      +41     
+ Misses       1155     1132      -23     
Impacted Files Coverage Δ
library/src/ipfs_client/gateways.cc 46.42% <94.44%> (+13.09%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@John-LittleBearLabs John-LittleBearLabs changed the title Gwenv Overriding initial gateway list with environment variable Jun 16, 2023
@John-LittleBearLabs John-LittleBearLabs marked this pull request as ready for review June 16, 2023 05:31
See IPFS_GATEWAY .
Started Conan build.
See IPFS_GATEWAY .
Started Conan build.
Doxygen built from Conan
if there's an install.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant