adapt the linker sections usage to mach-o #1091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"make test" on macOS: ``` using runner: ./runners/test_runner found 19 suites, 188 cases, 11242/11770 permutations running test_alloc: 12/12 cases, 207/207 perms running test_attrs: 4/4 cases, 20/20 perms running test_badblocks: 4/4 cases, 300/300 perms running test_bd: 5/5 cases, 85/85 perms running test_compat: 17/17 cases, 205/205 perms running test_dirs: 15/15 cases, 450/450 perms, 1756pls! running test_entries: 8/8 cases, 32/32 perms running test_evil: 8/8 cases, 105/105 perms running test_exhaustion: 5/5 cases, 85/85 perms running test_files: 10/10 cases, 7155/7155 perms, 9410pls! running test_interspersed: 4/4 cases, 190/190 perms, 2835pls! running test_move: 17/17 cases, 161/161 perms, 157pls! running test_orphans: 6/6 cases, 50/50 perms, 846pls! running test_paths: 33/33 cases, 325/325 perms running test_powerloss: 2/2 cases, 21/21 perms running test_relocations: 4/4 cases, 68/68 perms, 1612pls! running test_seek: 10/10 cases, 195/195 perms, 1050pls! running test_superblocks: 17/17 cases, 318/318 perms, 1437pls! running test_truncate: 7/7 cases, 1270/1270 perms, 9691pls! done: 11242/11242 passed, 0/11242 failed, 28794pls!, in 585.76s ```
Tests passed ✓, Code: 17116 B (+0.0%), Stack: 1448 B (+0.0%), Structs: 812 B (+0.0%)
|
|
Hi @yamt, sorry for the late response, thanks for this. Seems reasonable to me, will bring this in next patch release. You probably already know this, but there's no testing on Mac, so no promises this doesn't break in the future. |
geky
approved these changes
May 1, 2025
|
Oh, funny story, this is getting replace by yet-another-test-framework-rewrite in the pipeline (for better or worse upstreaming has not been a big priority). To instead use a precomputed array with Will still merge as a temporary solution. |
geky
added
needs minor version
geky
added
enhancement
and removed
needs minor version
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"make test" on macOS: