Use multi-facet charts with multiple inputs#7
Merged
jonatanklosko merged 1 commit intolivebook-dev:mainfrom Oct 21, 2025
Merged
Use multi-facet charts with multiple inputs#7jonatanklosko merged 1 commit intolivebook-dev:mainfrom
jonatanklosko merged 1 commit intolivebook-dev:mainfrom
Conversation
Contributor
|
Looks great! Please let us know once it is merged upstream! |
|
It is very much merged, albeit with minor adjustments. But all should work, if not please let me know :) Sorry for the delay, to make up for it I already released it in 1.5.0 (also includes 1.19 compilation warning fixes). Also, have a bunny:
|
jonatanklosko
changed the title
Member
|
@madlep published in v0.1.1 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Displaying Benchee benchmarks with multiple inputs get combined into one chart output which makes the result unclear.
Instead, display these as different facets
Depends on bencheeorg/benchee#476 in Benchee to expose
input_nameinTable.Readerto get the input name to facet on.Example with no inputs (same as current behavior)
Example with inputs
Example LiveBook with examples: https://gist.github.com/madlep/e47e183b535e9213e53ec99eba6c9dcd