Introducing Git file storage #3056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

aleDsz merged 29 commits into main from ale-git-file-storage

Sep 22, 2025

+1,528 −140

Member

aleDsz commented Sep 10, 2025

The git file storage requires the Git and SSH to run.

To run the tests, you must specify the TEST_GIT_SSH_KEY environment variable with the content of your Github SSH Deploy Key/User's SSH Key

aleDsz added 9 commits

September 10, 2025 14:29


          Remove root layout for errors

4cb6b5c


          Fix function spec

a252a49


          Update Team connection status in real-time

1c582d6


          Use FileSystem.Utils.id/3 instead

c37f8b9


          Minor improvements

d098033


          Implement the Git file storage

82b7432


          Disable add menu if file system is not writable

79cb0e1


          Add tests

c96ea9f


          Add SSH to Dockerfile

ebfeadf

aleDsz requested review from hugobarauna, josevalim and jonatanklosko

September 10, 2025 18:52

aleDsz self-assigned this


          Update test workflow to use the git ssh key

f3f86e9

hugobarauna reviewed

View reviewed changes

test/livebook_teams/web/hub/edit_live_test.exs Outdated Show resolved Hide resolved

josevalim reviewed

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

josevalim reviewed

View reviewed changes

lib/livebook/file_system/git/client.ex Outdated Show resolved Hide resolved

josevalim reviewed

View reviewed changes

lib/livebook/hubs/team_client.ex Outdated Show resolved Hide resolved

josevalim reviewed

View reviewed changes

lib/livebook/zta/livebook_teams.ex Outdated Show resolved Hide resolved

josevalim reviewed

View reviewed changes

lib/livebook_web/plugs/user_plug.ex Outdated Show resolved Hide resolved


          Revert some changes

fe2dda9

josevalim reviewed

View reviewed changes

lib/livebook/file_system/git/client.ex Outdated Show resolved Hide resolved

josevalim reviewed

View reviewed changes

lib/livebook/file_system/git/client.ex Outdated Show resolved Hide resolved

josevalim reviewed

View reviewed changes

lib/livebook/file_system/git/client.ex Outdated Show resolved Hide resolved

aleDsz added 6 commits

September 11, 2025 16:04


          Apply review comments

6161ef6


          Allow Git file storage for personal workspace

23b5291


          Redact git ssh key from being printed

d7c0b88


          Update file system protocol w/ mounting functions

ba983e5


          Improve TeamsRPC when creating a new file system

4b01a8b


          Add gen server to manage mountable file systems

f0ce072

aleDsz requested a review from josevalim

September 18, 2025 16:01


          Fix receive timeout

776fb20

josevalim requested changes

View reviewed changes

Contributor

josevalim left a comment

Some initial batch of suggestions :)

lib/livebook/file_system/local.ex Outdated Show resolved Hide resolved

lib/livebook/file_system/mounter.ex Outdated Show resolved Hide resolved

lib/livebook/file_system/git/client.ex Outdated Show resolved Hide resolved

lib/livebook/hubs/broadcasts.ex Outdated Show resolved Hide resolved


          Apply review comments

b1586b4

aleDsz requested a review from josevalim

September 19, 2025 21:39

josevalim reviewed

View reviewed changes

lib/livebook/file_system/mounter.ex Show resolved Hide resolved

josevalim reviewed

View reviewed changes

lib/livebook/file_system/mounter.ex Outdated Show resolved Hide resolved

josevalim reviewed

View reviewed changes

lib/livebook_web/live/hub/file_system_form_component.ex Outdated Show resolved Hide resolved

josevalim approved these changes

View reviewed changes

Contributor

josevalim left a comment

Only some nits now and we are ready to ship!!!!

aleDsz added 5 commits

September 22, 2025 11:20


          Apply review comments

bd86dff


          Keys from the user input still needs normalization

232b3ac


          Add specs

a96aa6a


          Don't show read-only file systems

b88f443


          Use default dir when saving with read-only file storage

c0184bd

jonatanklosko reviewed

View reviewed changes

lib/livebook/file_system/git.ex Outdated Show resolved Hide resolved

aleDsz added 5 commits

September 22, 2025 13:24


          Apply review comments

313d257


          Update tests for the ssh key normalization change

4a8ebc1


          There's no need anymore to use the .ssh folder

b04cffc


          Increase the assert timeout for intermittent tests

9ff9834


          Apply suggestion from code review

209d9bf

aleDsz requested a review from jonatanklosko

September 22, 2025 16:58

jonatanklosko approved these changes

View reviewed changes

Member

jonatanklosko left a comment

🔥🐈

aleDsz merged commit 435a668 into main

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet