Fix file input in multi-node deployment#3130
Merged
jonatanklosko merged 1 commit intomainfrom Feb 3, 2026
Merged
Conversation
josevalim
reviewed
Feb 3, 2026
| try do | ||
| source_path | ||
| |> File.stream!(64_000, []) | ||
| |> Enum.each(fn chunk -> IO.binwrite(file_pid, chunk) end) |
Contributor
There was a problem hiding this comment.
I think you can also use File.copy by passing two pids (the one in the open file and the one you received), or even a file path and a pid, and it will copy everything for you. But it is pretty much the same code as you have written here.
Member
Author
There was a problem hiding this comment.
Nice! With File.copy we would need to make sure to close both files in all failure cases, so this may actually be more code :D
josevalim
approved these changes
Feb 3, 2026
jonatanklosko
added a commit
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When LV uploads a file into a notebook file input, and the session is on a different node, we need to copy the file into the session node.