Handle a few cases of unchecked Task.Supervisor.start_child returns#3132
Merged
jonatanklosko merged 3 commits intolivebook-dev:mainfrom Feb 10, 2026
Merged
Conversation
|
|
Member
|
Thanks for the PR! Given that we really don't expect those |
The return value of start_child was silently discarded. Match
{:ok, _pid} so a failure crashes visibly instead of being lost.
The return value of start_child was silently discarded. Match
{:ok, _pid} so a failure crashes visibly instead of being lost.
The return value of start_child was silently discarded. Match
{:ok, _pid} so a failure crashes visibly instead of being lost.
QuinnWilton
force-pushed
the
fix/task-supervisor-errors
branch
from
cb33fd1 to
8945762
Compare
Contributor
Author
|
Sounds good! I just pushed up the simplified code :) |
jonatanklosko
approved these changes
Feb 10, 2026
Member
jonatanklosko
left a comment
jonatanklosko
left a comment
There was a problem hiding this comment.
@QuinnWilton perfect, thanks!
The CI failures are unrelated, I will fix those :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are all very minor issues that came up while I was doing some static analysis. They probably won't show up too often in practice, so I don't know whether these are cases you're concerned with, but I thought I'd open the PRs to flag the issues anyway!