Skip to content

Conversation

@dipak140
Copy link
Contributor

@dipak140 dipak140 commented Jan 4, 2025

feat: add suspend function to publish DTMF signals

  • Implement publishDTMF similar to localparticipant.publishDtmf in client-sdk-js
  • Wrap the SipDTMF in a DataPacket and send it via the engine
  • Enforce a maximum data size limit (RTCEngine.MAX_DATA_PACKET_SIZE)

Add publishDTMF command.
@changeset-bot
Copy link

changeset-bot bot commented Jan 4, 2025

🦋 Changeset detected

Latest commit: 4000772

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
client-sdk-android Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Jan 4, 2025

CLA assistant check
All committers have signed the CLA.

@davidliu
Copy link
Contributor

davidliu commented Jan 5, 2025

Looks like the build failed to formatting errors, you can fix by running ./gradlew spotlessApply.

@dipak140 dipak140 requested a review from davidliu January 5, 2025 11:46
@davidliu davidliu merged commit 4f4432b into livekit:main Jan 6, 2025
2 checks passed
@davidliu davidliu mentioned this pull request Jan 6, 2025
jeankruger pushed a commit to jeankruger/client-sdk-android that referenced this pull request May 1, 2025
…ivekit#576)

* Update LocalParticipant.kt

Add publishDTMF command.

* Update LocalParticipant.kt

* spotless apply and setKind

* Create hungry-peas-bow.md

---------

Co-authored-by: David Zhao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants