Skip to content

Audio changes #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidliu merged 2 commits into from
Jan 9, 2025
Merged

Audio changes #579

davidliu merged 2 commits into from
Jan 9, 2025

Conversation

@davidliu
Copy link
Contributor

@davidliu davidliu commented Jan 9, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2025

🦋 Changeset detected

Latest commit: 65c59c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
client-sdk-android Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

tuan-jason
tuan-jason reviewed Jan 9, 2025
View reviewed changes
livekit-android-sdk/src/main/java/io/livekit/android/audio/AudioSwitchHandler.kt
AudioDevice.WiredHeadset::class.java,
AudioDevice.Earpiece::class.java,
AudioDevice.Speakerphone::class.java,
AudioDevice.Earpiece::class.java,
Copy link

@tuan-jason tuan-jason Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidliu I guess this fix is for: #580?
If that's the case, I'm curious what will become the active audio output in case we setup custom preferredDeviceList in which Earpiece is the first one, then disconnect/reconnect to room? Will that be Speakerphone or Earpiece with this fix?

Copy link
Contributor Author

@davidliu davidliu Jan 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didnt see that bug before making this change; our other SDKs use this ordering, so this is to align with that.

Connecting/disconnecting shouldn't change or reset the order, if it does, then that's a bug.

Copy link

@tuan-jason tuan-jason Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. If you have time, could you take a look at the bug please? I think that might be related.
Thanks a lot.

@davidliu davidliu merged commit 34c1983 into main Jan 9, 2025
2 checks passed
@davidliu davidliu deleted the dl/audio_switch_defaults branch January 9, 2025 12:17
@davidliu davidliu mentioned this pull request Jan 9, 2025
Merged
@adrian-niculescu
Copy link
Contributor

adrian-niculescu commented Jan 21, 2025

Hi, @davidliu, the doc comment fro preferredDeviceList still has the old ordering with Earpiece being first before Speakerphone.

@davidliu
Copy link
Contributor Author

davidliu commented Jan 22, 2025

@adrian-niculescu Thanks for reminding me. Fixed in #584.

jeankruger pushed a commit to jeankruger/client-sdk-android that referenced this pull request May 1, 2025
@davidliu @jeankruger
Audio changes (livekit#579)
c4f6f6c 
* Explicitly expose AudioSwitchHandler

* Default prioritizing speaker over earpiece
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tuan-jason tuan-jason tuan-jason left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@davidliu @adrian-niculescu @tuan-jason