Skip to content

Remove unneeded suspend modifier from registerRpcMethod #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidliu merged 1 commit into from
Sep 9, 2025
Merged

Remove unneeded suspend modifier from registerRpcMethod #757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fifty-pans-explain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"client-sdk-android": patch
---

Remove unneeded suspend modifier from registerRpcMethod
2 changes: 1 addition & 1 deletion livekit-android-sdk/src/main/java/io/livekit/android/room/Room.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1103,7 +1103,7 @@ constructor(
)

// ----------------------------------- RpcManager ------------------------------------//
override suspend fun registerRpcMethod(method: String, handler: RpcHandler) {
override fun registerRpcMethod(method: String, handler: RpcHandler) {
localParticipant.registerRpcMethod(method, handler)
}

Expand Down
2 changes: 1 addition & 1 deletion livekit-android-sdk/src/main/java/io/livekit/android/room/participant/LocalParticipant.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1028,7 +1028,7 @@ internal constructor(
* @see RpcInvocationData
* @see performRpc
*/
override suspend fun registerRpcMethod(
override fun registerRpcMethod(
method: String,
handler: RpcHandler,
) {
Expand Down
3 changes: 1 addition & 2 deletions livekit-android-sdk/src/main/java/io/livekit/android/room/rpc/RpcManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,7 @@ interface RpcManager {
* @see RpcInvocationData
* @see performRpc
*/
@Suppress("RedundantSuspendModifier")
suspend fun registerRpcMethod(
fun registerRpcMethod(
method: String,
handler: RpcHandler,
)
Expand Down