#296 Fix camera indicator remaining on after network disconnection #798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fa6bf5e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Disposed orphaned tracks from failed reconnection attempts. When reconnection fails after prepareForFullReconnect() was called, tracks were moved to the republishes list but never disposed when the room disconnected permanently, leaving camera resources allocated. Fixes livekit#296
adrian-niculescu
force-pushed
the
fix/camera-indicator-orphaned-tracks
branch
from
dfe2940 to
fa6bf5e
Compare
davidliu
approved these changes
Nov 16, 2025
Contributor
|
Thanks for the PR! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #296
Problem
Camera active indicator remains on indefinitely when a Room is disconnected due to network failure (e.g., turning off WiFi/mobile data). This issue was reported in #296 and affects privacy, user experience, and battery life.
Root Cause
When network disconnection triggers reconnection attempts:
LocalParticipant.prepareForFullReconnect()clearstrackPublicationsand moves tracks to arepublisheslist for later republishingLocalParticipant.cleanup()only disposes tracks intrackPublications(which is now empty)republisheslist are orphaned and never disposed, leaving camera resources allocatedSolution
Modified
LocalParticipant.cleanup()to also dispose tracks from therepublisheslist that were saved for reconnection but never got republished. This ensures proper camera resource cleanup even when reconnection fails.Testing
Tested the fix by:
The camera indicator now properly turns off after failed reconnection attempts.
cc @davidliu