#808 Fixed ProGuard crash with Klaxon reflection-based classes #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added @keep annotations to AgentAttributes and related classes that use Klaxon for JSON parsing. Updated ProGuard rules to keep Klaxon library classes. This fixes the 'Couldn't find a suitable constructor' crash that occurred in release builds with minification enabled.
🦋 Changeset detectedLatest commit: 0e1d58d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@davidliu , this fixes the release crash described in #808
Commit 4bf585e introduced two data classes (
AgentAttributesandTranscriptionAttributes) that use Klaxon for JSON parsing via reflection. However, no ProGuard rules were added to protect these classes from obfuscation.