Skip to content

Fixed PeerConnectionTransport coroutine scope not being cancelled on close #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidliu merged 1 commit into from
Nov 25, 2025
Merged

Fixed PeerConnectionTransport coroutine scope not being cancelled on close #818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-pct-scope-not-cancelled.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"client-sdk-android": patch
---

Fixed PeerConnectionTransport coroutine scope not being cancelled on close.
2 changes: 2 additions & 0 deletions livekit-android-sdk/src/main/java/io/livekit/android/room/PeerConnectionTransport.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ import io.livekit.android.webrtc.peerconnection.launchBlockingOnRTCThread
import kotlinx.coroutines.CoroutineDispatcher
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.SupervisorJob
import kotlinx.coroutines.cancel
import kotlinx.coroutines.runBlocking
import livekit.org.webrtc.IceCandidate
import livekit.org.webrtc.MediaConstraints
Expand Down Expand Up @@ -309,6 +310,7 @@ constructor(
isClosed.set(true)
peerConnection.dispose()
}
coroutineScope.cancel()
}

fun updateRTCConfig(config: RTCConfiguration) {
Expand Down