Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-camera-events-dispatch-race.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"client-sdk-android": patch
---

Fixed data race in `CameraEventsDispatchHandler` by using `CopyOnWriteArraySet` for thread-safe iteration.
5 changes: 5 additions & 0 deletions .changeset/fix-signal-client-volatile.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"client-sdk-android": patch
---

Fix thread visibility issues in SignalClient that could cause messages to be silently dropped.
5 changes: 5 additions & 0 deletions .changeset/fix-track-bitrates-race-condition.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"client-sdk-android": patch
---

Fixed race condition in `PeerConnectionTransport.trackBitrates` by ensuring writes happen on the RTC thread.
Original file line number Diff line number Diff line change
Expand Up @@ -325,11 +325,15 @@ constructor(
}

fun registerTrackBitrateInfo(cid: String, trackBitrateInfo: TrackBitrateInfo) {
trackBitrates[TrackBitrateInfoKey.Cid(cid)] = trackBitrateInfo
executeRTCIfNotClosed {
trackBitrates[TrackBitrateInfoKey.Cid(cid)] = trackBitrateInfo
}
}

fun registerTrackBitrateInfo(transceiver: RtpTransceiver, trackBitrateInfo: TrackBitrateInfo) {
trackBitrates[TrackBitrateInfoKey.Transceiver(transceiver)] = trackBitrateInfo
executeRTCIfNotClosed {
trackBitrates[TrackBitrateInfoKey.Transceiver(transceiver)] = trackBitrateInfo
}
}

suspend fun isConnected(): Boolean {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,14 @@ constructor(
private val ioDispatcher: CoroutineDispatcher,
private val networkInfo: NetworkInfo,
) : WebSocketListener() {
@Volatile
var isConnected = false
private set

@Volatile
private var currentWs: WebSocket? = null

@Volatile
private var isReconnecting: Boolean = false
var listener: Listener? = null
internal var serverVersion: Semver? = null
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2023-2024 LiveKit, Inc.
* Copyright 2023-2025 LiveKit, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -17,61 +17,54 @@
package io.livekit.android.room.track.video

import livekit.org.webrtc.CameraVideoCapturer.CameraEventsHandler
import java.util.concurrent.CopyOnWriteArraySet

/**
* Dispatches CameraEventsHandler callbacks to registered handlers.
*/
class CameraEventsDispatchHandler : CameraEventsHandler {
private val handlers = mutableSetOf<CameraEventsHandler>()
private val handlers = CopyOnWriteArraySet<CameraEventsHandler>()

@Synchronized
fun registerHandler(handler: CameraEventsHandler) {
handlers.add(handler)
}

@Synchronized
fun unregisterHandler(handler: CameraEventsHandler) {
handlers.remove(handler)
}

override fun onCameraError(errorDescription: String) {
val handlersCopy = handlers.toMutableSet()
for (handler in handlersCopy) {
for (handler in handlers) {
handler.onCameraError(errorDescription)
}
}

override fun onCameraDisconnected() {
val handlersCopy = handlers.toMutableSet()
for (handler in handlersCopy) {
for (handler in handlers) {
handler.onCameraDisconnected()
}
}

override fun onCameraFreezed(errorDescription: String) {
val handlersCopy = handlers.toMutableSet()
for (handler in handlersCopy) {
for (handler in handlers) {
handler.onCameraFreezed(errorDescription)
}
}

override fun onCameraOpening(cameraName: String) {
val handlersCopy = handlers.toMutableSet()
for (handler in handlersCopy) {
for (handler in handlers) {
handler.onCameraOpening(cameraName)
}
}

override fun onFirstFrameAvailable() {
val handlersCopy = handlers.toMutableSet()
for (handler in handlersCopy) {
for (handler in handlers) {
handler.onFirstFrameAvailable()
}
}

override fun onCameraClosed() {
val handlersCopy = handlers.toMutableSet()
for (handler in handlersCopy) {
for (handler in handlers) {
handler.onCameraClosed()
}
}
Expand Down