Fixed Room getting stuck in CONNECTING state after failed connect attempts. #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…empts. Previously, if Room.connect() failed (due to network errors, invalid URL/token, TLS errors, etc.), the Room would remain in CONNECTING state, causing subsequent connect attempts to throw IllegalStateException. Now the Room properly resets to DISCONNECTED state and emits a Disconnected event with JOIN_FAILURE reason, allowing retry attempts.
🦋 Changeset detectedLatest commit: b606eee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
IllegalStateExceptionDisconnectedevent withJOIN_FAILUREreason on connect failureTest plan
connectFailureResetsStateToDisconnectedtest verifying state reset and event emissionconnectRetryAfterFailureSucceedstest verifying retry works after failure