-
Notifications
You must be signed in to change notification settings - Fork 123
UniFFI trial #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
UniFFI trial #750
Conversation
48449a0 to
41bd64c
Compare
| pub struct Claims { | ||
| pub exp: u64, | ||
| pub iss: String, | ||
| pub nbf: u64, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] can we use SystemTime instead?
Makes clear what comes from uniffi
Allows client to access the version specified in Cargo.toml
* Unverified token * CR: Names * CR: Test token
a028a03 to
3faab50
Compare
|
The I'd also commit (local) cc @1egoman |
# Conflicts: # Cargo.lock
|
I'll try to complete the Swift distribution path in the meantime. |
|
Here's more or less everything we need for local distribution, the tricky part is: [tasks.swift-generate-manifest.env]
SPM_URL = { value = "https://dummy.com" }
SPM_CHECKSUM = { value = "1234" }Let's assume the following workflow:
optionally:
Alternatively, we can skip |
|
I made a manual pre-release here: https://github.com/livekit/livekit-uniffi-xcframework @ladvoc if you're able to finish the release pipeline here, that would be cool (artifact is OK as mentioned above). |
livekit-uniffi/Makefile.toml
Outdated
| --platforms maccatalyst \ | ||
| --platforms visionos \ | ||
| --platforms tvos \ | ||
| --lib-type dynamic \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And one more thing @ladvoc static release is still ~40MB whereas dylib ~1.8MB.
Dynamic one won't pass AppStore validation (we'd need to wrap it in a Framework).
90426: Invalid Swift Support. The SwiftSupport folder is missing. Rebuild your app using the current public (GM) version of Xcode and resubmit it.
I'd rather go for stripping the static one further, any ideas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iOS in --release profile:
Ar Archive - 47 MB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, looks like DEAD_CODE_STRIPPING does the job and the bundle size increase is negligible (0.1 MB), moved back to static 729bc10
It also passes 🍏 validation 👍
I'm still open to optimization ideas 😄
No description provided.