-
Notifications
You must be signed in to change notification settings - Fork 129
add udp jumboframe support #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #527 +/- ##
==========================================
- Coverage 65.25% 63.83% -1.43%
==========================================
Files 51 32 -19
Lines 6588 6196 -392
==========================================
- Hits 4299 3955 -344
+ Misses 1915 1830 -85
- Partials 374 411 +37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pkg/config/config.go
Outdated
| ListenIP string `yaml:"listen_ip"` | ||
|
|
||
| // ENABLE JUMBO FRAME FOR UDP | ||
| UDPJumboFrame bool `yaml:"udp_jumbo_frame"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just expose it as udp_mtu_size instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There’s not much point in managable limit, since it only skipping the packet and logging an error. And there’s no handler for managing oversized data anyway.
Also, keep in mind how the transport package uses this value — it currently subtracts 200 from the initial limit, so you don’t have full control if the package changes in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed it to UDPMaxPayload to indicate that it's not an MTU specifically. We may use it later and propagate it down to the sipgo package.
No description provided.