Skip to content

Conversation

@zusrut
Copy link
Contributor

@zusrut zusrut commented Nov 21, 2025

No description provided.

@zusrut zusrut requested a review from a team as a code owner November 21, 2025 20:49
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.83%. Comparing base (0460b40) to head (3a7997d).
⚠️ Report is 192 commits behind head on main.

Files with missing lines Patch % Lines
pkg/sip/service.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #527      +/-   ##
==========================================
- Coverage   65.25%   63.83%   -1.43%     
==========================================
  Files          51       32      -19     
  Lines        6588     6196     -392     
==========================================
- Hits         4299     3955     -344     
+ Misses       1915     1830      -85     
- Partials      374      411      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ListenIP string `yaml:"listen_ip"`

// ENABLE JUMBO FRAME FOR UDP
UDPJumboFrame bool `yaml:"udp_jumbo_frame"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just expose it as udp_mtu_size instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s not much point in managable limit, since it only skipping the packet and logging an error. And there’s no handler for managing oversized data anyway.
Also, keep in mind how the transport package uses this value — it currently subtracts 200 from the initial limit, so you don’t have full control if the package changes in the future.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed it to UDPMaxPayload to indicate that it's not an MTU specifically. We may use it later and propagate it down to the sipgo package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants