Skip to content

Conversation

@holzgeist
Copy link
Contributor

Disclaimer: Fix was done by copilot
Discovery and testing was manual work

@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2025

⚠️ No Changeset found

Latest commit: c760bfc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lukasIO lukasIO requested a review from 1egoman December 2, 2025 12:36
@1egoman
Copy link
Contributor

1egoman commented Dec 10, 2025

@holzgeist Sorry it's taken me a bit to get to taking a look at this! Would you be able to add some context to the pull request description outlining the issue this code fixes? Is it by chance related to #8 / #9 ?

That being said, I tried it out your changes locally in the example app and it doesn't seem to break any of the existing behavior. Reading the code though my guess is that the example app may not exercise the edge cases, so before merging something like this I want to make sure those scenarios are properly captured to protect against any potential regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants