WIP add batch-size 2 versions to trt builds #220
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliteprox
reviewed
May 22, 2025
Comment on lines
+84
to
+93
| python src/comfystream/scripts/build_trt.py \ | ||
| --model /workspace/ComfyUI/models/unet/dreamshaper-8-dmd-1kstep.safetensors \ | ||
| --out-engine /workspace/ComfyUI/output/tensorrt/dynamic-dreamshaper8_SD15_dyn-b-${batch_size}-h-512-704-w-320-384-448_00001_.engine \ | ||
| --width 384 \ | ||
| --height 704 \ | ||
| --min-width 320 \ | ||
| --min-height 512 \ | ||
| --max-width 448 \ | ||
| --max-height 704 \ | ||
| --batch-size $batch_size |
Collaborator
There was a problem hiding this comment.
This engine is not used by ai-runner/daydream and is only for example workflows. We should at least exclude it from the batch loop to minimize length of build process. I'd also be fine with removing it entirely for now. wdyt?
Author
There was a problem hiding this comment.
That makes sense, given that I primarily created this branch to unblock testing with these models for the daydream workflow - we don't need or want to deploy these ( yet )
Collaborator
|
Closing in favor of #442 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #216
WIP.