Skip to content

Conversation

mattf
Copy link
Collaborator

@mattf mattf commented Sep 8, 2025

What does this PR do?

enables completions storage when using llama stack build --providers -

  • GET /v1/chat/completions
  • GET /v1/chat/completions/{id}

todo: llama stack build and distro codegen should use the same code paths

Test Plan

ci

enables completions storage when using `llama stack build --providers` -
 - GET /v1/chat/completions
 - GET /v1/chat/completions/{id}

todo: llama stack build and distro codegen should use the same code paths
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 8, 2025
@mattf mattf marked this pull request as ready for review September 8, 2025 14:29
@cdoern
Copy link
Contributor

cdoern commented Sep 8, 2025

todo: llama stack build and distro codegen should use the same code paths

yup +1

Copy link
Contributor

@ashwinb ashwinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure why not

@ashwinb ashwinb merged commit dd1f946 into llamastack:main Sep 9, 2025
44 checks passed
leseb pushed a commit that referenced this pull request Sep 10, 2025
# What does this PR do?

enables completions storage when using `llama stack build --providers` -
 - GET /v1/chat/completions
 - GET /v1/chat/completions/{id}

todo: llama stack build and distro codegen should use the same code
paths

## Test Plan

ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants