- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.2k
 
ci: add pre-commit check ensuring FIPS compliance #3899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            franciscojavierarceo
  merged 1 commit into
  llamastack:main
from
nathan-weinberg:fips-check
  
      
      
   
  Oct 29, 2025 
      
    
                
     Merged
            
            ci: add pre-commit check ensuring FIPS compliance #3899
                    franciscojavierarceo
  merged 1 commit into
  llamastack:main
from
nathan-weinberg:fips-check
  
      
      
   
  Oct 29, 2025 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    331ea82    to
    620e48f      
    Compare
  
    
              
                    franciscojavierarceo
  
              
              requested changes
              
                  
                    Oct 24, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lint failures.
620e48f    to
    a7f2886      
    Compare
  
    | 
           cc @rhdedgar  | 
    
688a9a7    to
    fab936d      
    Compare
  
    
              
                    mattf
  
              
              reviewed
              
                  
                    Oct 28, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be a grep like the asyncio or logging checks?
          
  | 
    
c4a5449    to
    92234d0      
    Compare
  
    this commit adds a new pre-commit hook to scan for non-FIPS compliant function usage within llama-stack Assisted-by: claude-4-sonnet Signed-off-by: Nathan Weinberg <[email protected]>
92234d0    to
    656160b      
    Compare
  
    
              
                    mattf
  
              
              approved these changes
              
                  
                    Oct 28, 2025 
                  
              
              
            
            
              
                    franciscojavierarceo
  
              
              approved these changes
              
                  
                    Oct 29, 2025 
                  
              
              
            
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
What does this PR do?
this commit adds a new pre-commit hook to scan for non-FIPS compliant function usage within llama-stack
Closes #3427
Test Plan
Ran locally