Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize images in fototoon #1698

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

AdityaKrSingh26
Copy link

@AdityaKrSingh26 AdityaKrSingh26 commented Jan 7, 2025

Fix : #1551

Earlier the images were set as background image to the whole canvas as a result they were not resizable.
In this fix i have made the images as a sperate globe which is resizable.

After fix:

sugar.mp4

@AdityaKrSingh26
Copy link
Author

Hey @llaske please have a look at this

@llaske
Copy link
Owner

llaske commented Jan 12, 2025

It's nice but it broke the way of using the activity.
When the image icon is clicked it suppose to add a new page in the comic.
Now it's no longer possible to add page.

@AdityaKrSingh26
Copy link
Author

AdityaKrSingh26 commented Jan 13, 2025

It's nice but it broke the way of using the activity. When the image icon is clicked it suppose to add a new page in the comic. Now it's no longer possible to add page.

okay ..... i was not aware of that feature.
We can do 3 things:

  1. either add a button to add new page
  2. or add a new page when next page button is clicked if the current page is the last page.
  3. or we can also do one thing that on one page we can add only one image and when new image a new page is created.

@llaske
Copy link
Owner

llaske commented Jan 14, 2025

The better option is the third.

@AdityaKrSingh26
Copy link
Author

The better option is the third.

Okay i will work on this
Just one thing i would like to make sure is that going with option 3 we will have only one image per page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants