Solved Default Queen Promotion #1705
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llaske
changed the title
|
The UI of the dialog could be improved.
The icons size could be increase. |
|
Ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixed the issue #1704
Here's the video on how it works:
Screen.Recording.2025-01-13.at.3.49.58.PM.mov
Fixes:
Added a Promotion Dialog in Vue Template and CSS to it
Added handlePromotion function to handle the promoting activity
Note: I know we have to not disturb the indentation of original file but honestly the html template was very difficult to understand there were free line gap so I decided to change a little for better future development side and better understanding for a new comer