feat: anchor actuation timing on container start (additive) - #1838
Open
rubambiza wants to merge 5 commits into
Open
feat: anchor actuation timing on container start (additive)#1838rubambiza wants to merge 5 commits into
rubambiza wants to merge 5 commits into
Conversation
Assisted-By: Claude Code (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Gloire Rubambiza <gloire@ibm.com>
Assisted-By: Claude Code (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Gloire Rubambiza <gloire@ibm.com>
Assisted-By: Claude Code (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Gloire Rubambiza <gloire@ibm.com>
Assisted-By: Claude Code (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Gloire Rubambiza <gloire@ibm.com>
Assisted-By: Claude Code (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Gloire Rubambiza <gloire@ibm.com>
rubambiza
requested review from
Vezio,
achandrasekar,
kalantar,
maugustosilva,
mengmeiye and
namasl
as code owners
August 22, 2026 03:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a container-start timing anchor alongside the existing pod-create anchor, on both the
standalone (no-FMA) path and the FMA analysis output. Everything here is additive — no existing
column, field, or number changes — so nothing that currently consumes the pod-create anchor breaks.
Closes #1836.
Why
The standalone (no-FMA) baseline is measured from Pod creation (includes scheduling + container
startup), while FMA
T_actuationis measured from the requester container's start (excludes thatfront-matter). Comparing the two paths across a differing start instant is unsound. This surfaces a
consistent container-start number on both paths so a fair, same-anchor comparison is possible —
while keeping the pod-create numbers in place, since we don't know who else consumes them.
See #1836 for the full rationale; this also addresses the review comment.
Changes
workload/harnesses/nop_functions.py—get_container_start()(elapsed Ready − containerstate.running.startedAt, matches the container by name with a sole-container fallback); acontainer_startfield onBenchmarkVllmMetrics, captured and assigned next topod_start.llmdbenchmark/analysis/scripts/nop-analyze_results.py— prints aContainer Start(secs)linein the vLLM metrics; adds a
T_actuation_cstart(s)column (ready − container_start_timestamp) tothe FMA metrics table (missing anchor renders as
--, distinct from a real0.0).llmdbenchmark/analysis/benchmark_report/native_to_br0_1.py— mapscontainer_startthroughthe native->benchmark-report import (the hand-mapped converter otherwise dropped it).
container_startdefault gracefully to
0.0rather than erroring.Testing
Validated end-to-end on live standalone Qwen3-4B runs (container_start ~119s) and on existing FMA
4B result artifacts (container_start_timestamp present on every iteration).
Assisted-By: Claude Code