llvm-bump (#4321)

Co-authored-by: Ram Sunder <[email protected]>

lib/Conversion/ExportVerilog/PrepareForEmission.cpp

@@ -751,7 +751,7 @@ static void legalizeHWModule(Block &block, const LoweringOptions &options) {
       // if we aren't allowing local variable declarations.  The Verilog emitter
       // doesn't want to have to have to know how to synthesize a reg in the
       // case they have to be spilled for whatever reason.
-      if (!mlir::MemoryEffectOpInterface::hasNoEffect(&op)) {
+      if (!mlir::isMemoryEffectFree(&op)) {
         if (rewriteSideEffectingExpr(&op))
           continue;
       }
@@ -821,8 +821,8 @@ static void legalizeHWModule(Block &block, const LoweringOptions &options) {
     // right in general.  MLIR doesn't have a "fully associative" property.
     if (op.getNumOperands() > 2 && op.getNumResults() == 1 &&
         op.hasTrait<mlir::OpTrait::IsCommutative>() &&
-        mlir::MemoryEffectOpInterface::hasNoEffect(&op) &&
-        op.getNumRegions() == 0 && op.getNumSuccessors() == 0 &&
+        mlir::isMemoryEffectFree(&op) && op.getNumRegions() == 0 &&
+        op.getNumSuccessors() == 0 &&
         (op.getAttrs().empty() ||
          (op.getAttrs().size() == 1 && op.hasAttr("sv.namehint")))) {
       // Lower this operation to a balanced binary tree of the same operation.

lib/Dialect/FIRRTL/Transforms/IMDeadCodeElim.cpp

@@ -171,7 +171,7 @@ void IMDeadCodeElimPass::markBlockExecutable(Block *block) {
     else if (isa<FConnectLike>(op))
       // Skip connect op.
       continue;
-    else if (!mlir::MemoryEffectOpInterface::hasNoEffect(&op))
+    else if (!mlir::isMemoryEffectFree(&op))
       markUnknownSideEffectOp(&op);
 
     // TODO: Handle attach etc.

lib/Dialect/LLHD/Transforms/EarlyCodeMotionPass.cpp

@@ -59,7 +59,7 @@ void EarlyCodeMotionPass::runOnOperation() {
          iter != block->getOperations().end(); ++iter) {
       Operation &op = *iter;
       if (!isa<llhd::PrbOp>(op) && !isa<llhd::SigOp>(op) &&
-          (!mlir::MemoryEffectOpInterface::hasNoEffect(&op) ||
+          (!mlir::isMemoryEffectFree(&op) ||
            op.hasTrait<OpTrait::IsTerminator>()))
         continue;
 

lib/Dialect/SV/Transforms/HWCleanup.cpp

@@ -238,7 +238,7 @@ void HWCleanupPass::runOnProceduralRegion(Region &region) {
     }
 
     // Keep track of the last side effecting operation we've seen.
-    if (!mlir::MemoryEffectOpInterface::hasNoEffect(&op))
+    if (!mlir::isMemoryEffectFree(&op))
       lastSideEffectingOp = &op;
   }
 

lib/Dialect/SV/Transforms/PrettifyVerilog.cpp

@@ -283,7 +283,7 @@ bool PrettifyVerilogPass::splitAssignment(OpBuilder &builder, Value dst,
 /// operation so it can be sunk into multiple blocks. If there are no more uses
 /// in the current block, the op will be removed.
 void PrettifyVerilogPass::sinkOrCloneOpToUses(Operation *op) {
-  assert(mlir::MemoryEffectOpInterface::hasNoEffect(op) &&
+  assert(mlir::isMemoryEffectFree(op) &&
          "Op with side effects cannot be sunk to its uses.");
   auto block = op->getBlock();
   // This maps a block to the block local instance of the op.
@@ -403,7 +403,7 @@ void PrettifyVerilogPass::sinkExpression(Operation *op) {
     if (curOpBlock != op->user_begin()->getBlock()) {
       // Ok, we're about to make a change, ensure that there are no side
       // effects.
-      if (!mlir::MemoryEffectOpInterface::hasNoEffect(op))
+      if (!mlir::isMemoryEffectFree(op))
         return;
 
       op->moveBefore(*op->user_begin());
@@ -451,7 +451,7 @@ void PrettifyVerilogPass::sinkExpression(Operation *op) {
 
   // Ok, we're about to make a change, ensure that there are no side
   // effects.
-  if (!mlir::MemoryEffectOpInterface::hasNoEffect(op))
+  if (!mlir::isMemoryEffectFree(op))
     return;
 
   // Ok, we found a common ancestor between all the users that is deeper than