[ESI] Make AcceleratorConnection::disconnect virtual (#7554)

Currently, `AcceleratorConnection` implementations only have one "official" teardown entry point, being their destructors. However, this makes implementations susceptible to destructor race conditions, due to the various things that may be concurrently executing in implementation-owned resources. To provide users with more control during teardown, mark `AcceleratorConnection::disconnect` as virtual, allowing implementations to tear things down before destruction. Co-authored-by: Morten Borup Petersen <[email protected]>
llvm · Aug 26, 2024 · 5a669df · 5a669df
1 parent 66122eb
commit 5a669df
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/Dialect/ESI/runtime/cpp/include/esi/Accelerator.h b/lib/Dialect/ESI/runtime/cpp/include/esi/Accelerator.h
@@ -82,7 +82,7 @@ class AcceleratorConnection {
   Context &getCtxt() const { return ctxt; }
 
   /// Disconnect from the accelerator cleanly.
-  void disconnect();
+  virtual void disconnect();
 
   /// Request the host side channel ports for a particular instance (identified
   /// by the AppID path). For convenience, provide the bundle type.