[FIRRTL] Delete CheckCombCycles, remove -use-old-check-comb-cycles. (#…

…5410) CheckCombLoops has replaced this for some time now. Code lives on in version history if needed.
llvm · Jun 15, 2023 · a343950 · a343950
1 parent 5f9d04e
commit a343950
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 843 deletions.
diff --git a/include/circt/Dialect/FIRRTL/Passes.h b/include/circt/Dialect/FIRRTL/Passes.h
@@ -114,8 +114,6 @@ createBlackBoxReaderPass(std::optional<mlir::StringRef> inputPrefix = {});
 std::unique_ptr<mlir::Pass>
 createGrandCentralPass(bool instantiateCompanionOnly = false);
 
-std::unique_ptr<mlir::Pass> createCheckCombCyclesPass();
-
 std::unique_ptr<mlir::Pass> createCheckCombLoopsPass();
 
 std::unique_ptr<mlir::Pass> createSFCCompatPass();

diff --git a/include/circt/Dialect/FIRRTL/Passes.td b/include/circt/Dialect/FIRRTL/Passes.td
@@ -469,18 +469,6 @@ def GrandCentral : Pass<"firrtl-grand-central", "CircuitOp"> {
   ];
 }
 
-def CheckCombCycles : Pass<"firrtl-check-comb-cycles", "firrtl::CircuitOp"> {
-  let summary = "Check combinational cycles and emit errors";
-  let description = [{
-    This pass checks combinational cycles in the IR and emit errors.
-  }];
-  let options = [
-    Option<"printSimpleCycle", "print-simple-cycle", "bool", "true",
-      "Print a simple cycle instead of printing all operations in SCC">
-  ];
-  let constructor = "circt::firrtl::createCheckCombCyclesPass()";
-}
-
 def CheckCombLoops : Pass<"firrtl-check-comb-loops", "firrtl::CircuitOp"> {
   let summary = "Check combinational cycles and emit errors";
   let description = [{

diff --git a/include/circt/Firtool/Firtool.h b/include/circt/Firtool/Firtool.h
@@ -85,12 +85,6 @@ struct FirtoolOptions {
       "dedup", llvm::cl::desc("Deduplicate structurally identical modules"),
       llvm::cl::init(false), llvm::cl::cat(category)};
 
-  llvm::cl::opt<bool> useOldCheckCombCycles{
-      "use-old-check-comb-cycles",
-      llvm::cl::desc(
-          "Use old CheckCombCycles pass, that does not support aggregates"),
-      llvm::cl::init(false), llvm::cl::Hidden, llvm::cl::cat(category)};
-
   llvm::cl::opt<bool> grandCentralInstantiateCompanionOnly{
       "grand-central-instantiate-companion",
       llvm::cl::desc("Run Grand Central in a mode where the companion module "

diff --git a/lib/Dialect/FIRRTL/Transforms/CMakeLists.txt b/lib/Dialect/FIRRTL/Transforms/CMakeLists.txt
@@ -1,7 +1,6 @@
 add_circt_dialect_library(CIRCTFIRRTLTransforms
   AddSeqMemPorts.cpp
   BlackBoxReader.cpp
-  CheckCombCycles.cpp
   CheckCombLoops.cpp
   CreateSiFiveMetadata.cpp
   Dedup.cpp