[FIRRTL] Fix bug in GCT Taps XMRs #3415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug in Grand Central (GCT) Data/Mem Taps pass where Data Taps could be produced with invalid XMRs. An exhaustive test case is added that checks all permutations of upwards and downwards XMRs including corner cases where the tap module is a leaf and the root. Fixes #3414. Signed-off-by: Schuyler Eldridge <[email protected]>
seldridge
commented
Jun 24, 2022
Comment on lines
-850
to
-860
| if (port.nla && shortestPrefix->empty() && | ||
| port.nla.root() != rootModule.moduleNameAttr()) { | ||
| // This handles the case when nla is not considered for common prefix | ||
| // stripping. | ||
| auto rootMod = port.nla.root(); | ||
| for (auto p : path) { | ||
| if (rootMod == p->getParentOfType<FModuleOp>().getNameAttr()) | ||
| break; | ||
| addSymbol(getInnerRefTo(p)); | ||
| } | ||
| } |
There was a problem hiding this comment.
This block of code was surprisingly not covered by existing tests after 43035e7. The logic that merged NLA path with the computed instance paths made this unreachable (for the tests we had).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in Grand Central (GCT) Data/Mem Taps pass where Data Taps
could be produced with invalid XMRs. An exhaustive test case is added
that checks all permutations of upwards and downwards XMRs including
corner cases where the tap module is a leaf and the root.
Fixes #3414.
Signed-off-by: Schuyler Eldridge [email protected]