Skip to content

[ESI] Don't swallow exception in callback port wrapper #8913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[ESI] Don't swallow exception in callback port wrapper #8913

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions lib/Dialect/ESI/runtime/python/esiaccel/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
from concurrent.futures import Future
from typing import Any, Callable, Dict, List, Optional, Tuple, Type, Union
import sys
import traceback


def _get_esi_type(cpp_type: cpp.Type):
Expand Down Expand Up @@ -521,17 +520,13 @@ def connect(self, cb: Callable[[Any], Any]):

def type_convert_wrapper(cb: Callable[[Any], Any],
msg: bytearray) -> Optional[bytearray]:
try:
(obj, leftover) = self.arg_type.deserialize(msg)
if len(leftover) != 0:
raise ValueError(f"leftover bytes: {leftover}")
result = cb(obj)
if result is None:
return None
return self.result_type.serialize(result)
except Exception as e:
traceback.print_exception(e)
(obj, leftover) = self.arg_type.deserialize(msg)
if len(leftover) != 0:
raise ValueError(f"leftover bytes: {leftover}")
result = cb(obj)
if result is None:
return None
return self.result_type.serialize(result)

self.cpp_port.connect(lambda x: type_convert_wrapper(cb=cb, msg=x))
self.connected = True
Expand Down