[CIR] Add code generation options to lowering context #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lancern
force-pushed
the
codegen-options-in-lowering
branch
from
dfc37d8 to
aaae2e5
Compare
smeenai
reviewed
Nov 26, 2024
clang/lib/CIR/Dialect/Transforms/TargetLowering/CIRLowerContext.cpp
Outdated
Show resolved
Hide resolved
clang/lib/CIR/Dialect/Transforms/TargetLowering/LowerModule.cpp
Outdated
Show resolved
Hide resolved
Lancern
force-pushed
the
codegen-options-in-lowering
branch
from
aaae2e5 to
9edc30a
Compare
bcardosolopes
approved these changes
Nov 27, 2024
Lancern
force-pushed
the
codegen-options-in-lowering
branch
from
9edc30a to
41078e9
Compare
This PR adds `clang::CodeGenOptions` to the lowering context. Similar to `clang::LangOptions`, the code generation options are currently set to the default values when initializing the lowering context. Besides, this PR also adds a new attribute `#cir.opt_info`. The attribute is a module-level attribute and it holds optimization information such as the optimization level. The attribute is consumed when initializing the lowering context to populate the code generation options. CIRGen is updated to generate and attach this attribute to the module op.
Lancern
force-pushed
the
codegen-options-in-lowering
branch
from
1d23da2 to
c1c2ccc
Compare
| | `-O2` | 2 | 0 | | ||
| | `-O3` | 3 | 0 | | ||
| | `-Os` | 2 | 1 | | ||
| | `-Oz` | 2 | 2 | |
There was a problem hiding this comment.
This is super neat, thank you!
lanza
pushed a commit
that referenced
this pull request
Mar 18, 2025
This PR adds `clang::CodeGenOptions` to the lowering context. Similar to `clang::LangOptions`, the code generation options are currently set to the default values when initializing the lowering context. Besides, this PR also adds a new attribute `#cir.opt_level`. The attribute is a module-level attribute and it holds the optimization level (e.g. -O1, -Oz, etc.). The attribute is consumed when initializing the lowering context to populate the `OptimizationLevel` and the `OptimizeSize` field in the code generation options. CIRGen is updated to attach this attribute to the module op.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
clang::CodeGenOptionsto the lowering context. Similar toclang::LangOptions, the code generation options are currently set to the default values when initializing the lowering context.Besides, this PR also adds a new attribute
#cir.opt_level. The attribute is a module-level attribute and it holds the optimization level (e.g. -O1, -Oz, etc.). The attribute is consumed when initializing the lowering context to populate theOptimizationLeveland theOptimizeSizefield in the code generation options. CIRGen is updated to attach this attribute to the module op.