[CIR][CIRGen] virtual table pointer initialization without ctor #1283
+34
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardosolopes
requested changes
Jan 14, 2025
| @@ -468,6 +468,9 @@ struct MissingFeatures { | |||
| static bool mustProgress() { return false; } | |||
|
|
|||
| static bool skipTempCopy() { return false; } | |||
|
|
|||
| // https://clang.llvm.org/docs/PointerAuthentication.html | |||
| static bool pointerAuthentication() { return false; } | |||
There was a problem hiding this comment.
We already have ptrAuth, use that
bcardosolopes
approved these changes
Jan 14, 2025
lanza
pushed a commit
that referenced
this pull request
Mar 18, 2025
Corresponding [OG code](https://github.com/llvm/clangir/blob/ef20d053b3d78c9d4c135e2811b303b7e5016d30/clang/lib/CodeGen/CGExprConstant.cpp#L846). [OG generated code here](https://godbolt.org/z/x6q333dMn), one notable diff is we're missing `inrange` which is reported in [issue 886 ](#886). For now, I'm still using GlobalViewAttr to implement it so we can move things fast. But it might be worth considering approach [Comments in issue 258](#258), especially we could incoporate [inrange info](#886) to the attribute suggested there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding OG code.
OG generated code here, one notable diff is we're missing
inrangewhich is reported in issue 886 .For now, I'm still using GlobalViewAttr to implement it so we can move things fast.
But it might be worth considering approach Comments in issue 258, especially we could incoporate inrange info to the attribute suggested there.