[CIR] Rename cir.struct to cir.record and associated changes
#1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the initial upstreaming of `cir.struct` support, a request was made to rename `cir.struct` to `cir.record` for consistency with its multiple uses. This change makes the modification along with renaming various other related classes. I've attempted to also update variable names and comments to keep everything consistent.
andykaylor
requested review from
xlauko,
bcardosolopes,
erichkeane,
lanza and
dkolsen-pgi
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the initial upstreaming of
cir.structsupport, a request was made to renamecir.structtocir.recordfor consistency with its multiple uses. This change makes the modification along with renaming various other related classes. I've attempted to also update variable names and comments to keep everything consistent.This creates an unfortunate name collision between cir::RecordType and clang::RecordType, but the impact of that overlaps was relatively small.
The only intended behavioral change is in the names used in the emitted CIR files and diagnostics.