This repository was archived by the owner on Feb 21, 2026. It is now read-only.
[CIR] Add support for typeid l-value emission - #2000
Closed
lanza wants to merge 1 commit into
Closed
Conversation
lanza
requested review from
andykaylor,
bcardosolopes and
xlauko
as code owners
November 22, 2025 05:17
lanza
added a commit
that referenced
this pull request
Nov 22, 2025
Summary:
This patch implements support for emitting typeid expressions as
l-values in ClangIR, enabling code patterns such as:
const std::type_info& ti = typeid(MyClass);
auto& ref = typeid(int);
void foo(const std::type_info& ti) { foo(typeid(SomeType)); }
This is a common pattern in C++ code that uses RTTI for logging,
serialization, debugging, and type introspection.
Implementation:
The implementation follows the traditional LLVM CodeGen approach:
1. Added emitCXXTypeidExpr() in CIRGenExprCXX.cpp
- Handles both type operands (typeid(Type)) and expression operands
(typeid(expr))
- Retrieves the RTTI descriptor via getAddrOfRTTIDescriptor()
- Looks up the GlobalOp to determine the correct pointer type
- Creates a GetGlobalOp to materialize the address at runtime
- Polymorphic type vtable lookup is marked as NYI
2. Added emitCXXTypeidLValue() in CIRGenExpr.cpp
- Calls emitCXXTypeidExpr() to get the RTTI descriptor pointer
- Performs a bitcast from !u8i pointer to the proper type_info type
- Creates an LValue with appropriate alignment for reference binding
3. Extended the emitLValue() switch statement to handle CXXTypeidExpr
What works:
- typeid with type operands: typeid(int), typeid(MyClass)
- typeid with non-polymorphic expression operands: typeid(obj)
- Reference binding: const std::type_info& ti = typeid(...)
- Function argument passing: foo(typeid(...))
- Built-in types, class types, and struct types
What doesn't work yet:
- typeid with polymorphic types requiring vtable lookup
(e.g., typeid(*basePtr) where the dynamic type differs from static type)
This is marked with llvm_unreachable() and will be implemented separately.
Test Plan:
Added comprehensive test coverage in clang/test/CIR/CodeGen/typeid-lvalue.cpp
- Non-polymorphic struct types
- Expression operands
- Built-in types (int, double)
- Function argument passing
- All tests pass
Regression testing:
- All 394 CIR CodeGen tests pass (379 passed, 14 unsupported, 1 expected fail)
- Code formatted with clang-format
- Code checked with clang-tidy (warnings consistent with existing codebase)
Differential Revision: N/A
ghstack-source-id: 261e71d
Pull-Request: #2000
This was referenced Nov 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
This patch implements support for emitting typeid expressions as
l-values in ClangIR, enabling code patterns such as:
const std::type_info& ti = typeid(MyClass);
auto& ref = typeid(int);
void foo(const std::type_info& ti) { foo(typeid(SomeType)); }
This is a common pattern in C++ code that uses RTTI for logging,
serialization, debugging, and type introspection.
Implementation:
The implementation follows the traditional LLVM CodeGen approach:
Added emitCXXTypeidExpr() in CIRGenExprCXX.cpp
(typeid(expr))
Added emitCXXTypeidLValue() in CIRGenExpr.cpp
Extended the emitLValue() switch statement to handle CXXTypeidExpr
What works:
What doesn't work yet:
(e.g., typeid(*basePtr) where the dynamic type differs from static type)
This is marked with llvm_unreachable() and will be implemented separately.
Test Plan:
Added comprehensive test coverage in clang/test/CIR/CodeGen/typeid-lvalue.cpp
Regression testing:
Differential Revision: N/A