Improve MemoryEffect check

llvm · Jan 15, 2025 · 9eaaba9 · 9eaaba9
1 parent 72d83be
commit 9eaaba9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/llvm/include/llvm/Support/ModRef.h b/llvm/include/llvm/Support/ModRef.h
@@ -212,6 +212,10 @@ template <typename LocationEnum> class MemoryEffectsBase {
     return getWithoutLoc(Location::InaccessibleMem).doesNotAccessMemory();
   }
 
+  bool doesAccessInaccessibleMem() const {
+    return isModOrRefSet(getModRef(Location::InaccessibleMem));
+  }
+
   /// Whether this function only (at most) accesses argument and inaccessible
   /// memory.
   bool onlyAccessesInaccessibleOrArgMem() const {

diff --git a/llvm/lib/IR/IntrinsicInst.cpp b/llvm/lib/IR/IntrinsicInst.cpp
@@ -69,7 +69,7 @@ bool IntrinsicInst::mayLowerToFunctionCall(Intrinsic::ID IID) {
 bool IntrinsicInst::canAccessFPEnvironment(LLVMContext &C, Intrinsic::ID IID) {
   AttributeList Attrs = Intrinsic::getAttributes(C, IID);
   MemoryEffects ME = Attrs.getMemoryEffects();
-  return ME.onlyAccessesInaccessibleMem();
+  return ME.doesAccessInaccessibleMem();
 }
 
 //===----------------------------------------------------------------------===//