[X86] Add atomic vector tests for >1 sizes.#120316
Closed
Conversation
Vector types on atomics are assumed to be invalid by the verifier. However, this type can be valid if it is lowered by codegen.
Scalarize vector of atomic load in SelectionDAG.
When lowering atomic vector types with floats, selection can fail since this pattern is unsupported. To support this, floats can be casted to an integer type of the same size.
Atomic vectors with size >1 are lowered to calls. Adding their tests separately here.
arsenm
reviewed
Dec 18, 2024
| ; CHECK0-NEXT: retq | ||
| %ret = load atomic <32 x half>, ptr %x acquire, align 4 | ||
| ret <32 x half> %ret | ||
| } |
Contributor
There was a problem hiding this comment.
To repeat from the other thread, should also test a 1 x ptr, 1 x ptr addrspace(270), 1 x i8, 1 x i16 (plus with sext/zext of the results to <1 x i32/64>)
Contributor
Author
Contributor
There was a problem hiding this comment.
The call lowering seems like an accident
Collaborator
|
@jofrn close this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #117625, #111414, and #118793, atomic vector loads can be lowered. Atomic vectors with size >1 are lowered to calls. Adding their tests separately here.