-
Notifications
You must be signed in to change notification settings - Fork 13.3k
fix armv6kz LDREX definition #122965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix armv6kz LDREX definition #122965
Conversation
@llvm/pr-subscribers-clang @llvm/pr-subscribers-backend-arm Author: None (Un1q32) ChangesFixes #37901 This behavior is consistent with GCC Full diff: https://github.com/llvm/llvm-project/pull/122965.diff 1 Files Affected:
diff --git a/clang/lib/Basic/Targets/ARM.cpp b/clang/lib/Basic/Targets/ARM.cpp
index 61ee26d8863832..0fd5433a76402e 100644
--- a/clang/lib/Basic/Targets/ARM.cpp
+++ b/clang/lib/Basic/Targets/ARM.cpp
@@ -617,7 +617,8 @@ bool ARMTargetInfo::handleTargetFeatures(std::vector<std::string> &Features,
case 6:
if (ArchProfile == llvm::ARM::ProfileKind::M)
LDREX = 0;
- else if (ArchKind == llvm::ARM::ArchKind::ARMV6K)
+ else if (ArchKind == llvm::ARM::ArchKind::ARMV6K ||
+ ArchKind == llvm::ARM::ArchKind::ARMV6KZ)
LDREX = LDREX_D | LDREX_W | LDREX_H | LDREX_B;
else
LDREX = LDREX_W;
|
Please add a corresponding CHECK line to clang/test/Preprocessor/arm-acle-6.4.c |
Can you add a test? |
Is the CHECK line enough or do you want something more? My understanding is that the CHECK lines are tests, but I'm not sure since this was sent after the request for the CHECK line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yes, the CHECK is enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks LGTM. Let us know if we should squash and merge (I never know who has access).
Yeah I don't have access, please merge thank you |
Fixes #37901
This behavior is consistent with GCC