Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clang][Serialization] Add the missing block info #122976

Conversation

cachemeifyoucan
Copy link
Collaborator

HEADER_SEARCH_ENTRY_USAGE and VFS_USAGE were missing from the block info
block. Add the missing info so llvm-bcanalyzer can read them
correctly.

Created using spr 1.3.5
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:modules C++20 modules and Clang Header Modules labels Jan 14, 2025
@llvmbot
Copy link
Member

llvmbot commented Jan 14, 2025

@llvm/pr-subscribers-clang-modules

@llvm/pr-subscribers-clang

Author: Steven Wu (cachemeifyoucan)

Changes

HEADER_SEARCH_ENTRY_USAGE and VFS_USAGE were missing from the block info
block. Add the missing info so llvm-bcanalyzer can read them
correctly.


Full diff: https://github.com/llvm/llvm-project/pull/122976.diff

1 Files Affected:

  • (modified) clang/lib/Serialization/ASTWriter.cpp (+2)
diff --git a/clang/lib/Serialization/ASTWriter.cpp b/clang/lib/Serialization/ASTWriter.cpp
index 345d496a933123..0ae2157eed4ecc 100644
--- a/clang/lib/Serialization/ASTWriter.cpp
+++ b/clang/lib/Serialization/ASTWriter.cpp
@@ -1153,6 +1153,8 @@ void ASTWriter::WriteBlockInfoBlock() {
   RECORD(DIAGNOSTIC_OPTIONS);
   RECORD(HEADER_SEARCH_PATHS);
   RECORD(DIAG_PRAGMA_MAPPINGS);
+  RECORD(HEADER_SEARCH_ENTRY_USAGE);
+  RECORD(VFS_USAGE);
 
 #undef RECORD
 #undef BLOCK

@cachemeifyoucan cachemeifyoucan merged commit 1865048 into main Jan 15, 2025
11 checks passed
@cachemeifyoucan cachemeifyoucan deleted the users/cachemeifyoucan/spr/clangserialization-add-the-missing-block-info branch January 15, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:modules C++20 modules and Clang Header Modules clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants